Add switch #31
Merged
Add switch #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pante
added
difficulty: easy
kawaijoe
reviewed
Jun 1, 2024
Daviiddoo
added a commit
that referenced
this pull request
Jun 2, 2024
commit 3d82059 Author: Matthias Ngeo <[email protected]> Date: Sun Jun 2 15:31:14 2024 +0800 Add switch (#31) * WIP * Add golden tests * Commit from GitHub Actions (Forui Presubmit) * Fix PR issues --------- Co-authored-by: Pante <[email protected]>
Daviiddoo
added a commit
that referenced
this pull request
Jun 2, 2024
* Initial draft * clean up * next draft for review * Update button_style.dart * add style to ButtonContent * removed flutter hooks, implemented Tappable * Mob programming * fixed build issues * Left to test colors * colors tested * Rebase branch with master * Added SVG assets, cleaned up dart analysis issues * added tests * updateed with some of the parameters from gesture detector * Fbutton is ready * Implemented tappable * Commit from GitHub Actions (Forui Presubmit) * Update forui/lib/src/widgets/button/button.dart Co-authored-by: Matthias Ngeo <[email protected]> * Update forui/lib/src/widgets/button/button.dart Co-authored-by: Matthias Ngeo <[email protected]> * Update forui/lib/src/widgets/button/button.dart Co-authored-by: Matthias Ngeo <[email protected]> * Update forui/lib/src/widgets/button/button.dart Co-authored-by: Matthias Ngeo <[email protected]> * Update forui/lib/src/widgets/button/button.dart Co-authored-by: Matthias Ngeo <[email protected]> * Update forui/lib/src/widgets/button/button_style.dart Co-authored-by: Matthias Ngeo <[email protected]> * Fixed pr issues * Commit from GitHub Actions (Forui Presubmit) * Matthias Done??? * Update button.dart * Commit from GitHub Actions (Forui Presubmit) * Squashed commit of the following: commit 3d82059 Author: Matthias Ngeo <[email protected]> Date: Sun Jun 2 15:31:14 2024 +0800 Add switch (#31) * WIP * Add golden tests * Commit from GitHub Actions (Forui Presubmit) * Fix PR issues --------- Co-authored-by: Pante <[email protected]> --------- Co-authored-by: Matthias <[email protected]> Co-authored-by: Daviiddoo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29